From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18499 invoked by alias); 20 Jan 2010 21:01:34 -0000 Received: (qmail 18404 invoked by uid 22791); 20 Jan 2010 21:01:33 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jan 2010 21:01:26 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0KL1O4a025107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Jan 2010 16:01:25 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0KL1OkX003003; Wed, 20 Jan 2010 16:01:24 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o0KL1NSG009343; Wed, 20 Jan 2010 16:01:23 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id F0C60379965; Wed, 20 Jan 2010 14:01:22 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Fix a race by me - watchthreads-reorder.exp References: <20091217195026.GA21468@host0.dyn.jankratochvil.net> <20100119221228.GA30074@host0.dyn.jankratochvil.net> Reply-To: Tom Tromey Date: Wed, 20 Jan 2010 21:01:00 -0000 In-Reply-To: <20100119221228.GA30074@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 19 Jan 2010 23:12:28 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00512.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2010-01-19 Jan Kratochvil Jan> * gdb.threads/watchthreads-reorder.c (gdbstop_mutex): Remove. Jan> (thread1_func): Protect thread1_tid with thread1_tid_cond by Jan> thread1_tid_mutex. Remove gdbstop_mutex handling. Jan> (thread2_func): Protect thread2_tid with thread2_tid_cond by Jan> thread2_tid_mutex. Remove gdbstop_mutex handling. Jan> (main): Move thread1_tid_mutex and thread2_tid_mutex locks before Jan> pthread_create. Remove gdbstop_mutex handling. New comment. Replace Jan> pthread_cond_wait conditionalizations by while loops. Ok. Thanks. Tom