From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19965 invoked by alias); 9 Apr 2010 15:48:37 -0000 Received: (qmail 19954 invoked by uid 22791); 9 Apr 2010 15:48:36 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 15:48:32 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o39FmUZj022578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 9 Apr 2010 11:48:31 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o39FmUgP001513; Fri, 9 Apr 2010 11:48:30 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o39FmTZd023186; Fri, 9 Apr 2010 11:48:29 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 527D0379786; Fri, 9 Apr 2010 09:48:29 -0600 (MDT) From: Tom Tromey To: Phil Muldoon Cc: gdb-patches ml Subject: Re: [python][patch] PR pyton/11381 References: <4BBE1073.40703@redhat.com> Reply-To: tromey@redhat.com Date: Fri, 09 Apr 2010 15:48:00 -0000 In-Reply-To: <4BBE1073.40703@redhat.com> (Phil Muldoon's message of "Thu, 08 Apr 2010 18:20:51 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00248.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> This patch address PR 11381. Briefly there are cases when only Phil> children should be printed in a pretty-printer. This patch allows the Phil> printer's 'to_string' method to return the Python "None". If this is Phil> the case, the GDB pretty-printers will print nothing in place of Phil> to_string and also alter the preceding text slightly, stripping off Phil> leading spaces and the '=" text. What should happen if to_string returns None but there is no children method? I think we should not worry about corner cases like this, but even so we should explicitly decide that. Does the varobj code do something sensible when to_string returns None? I think there should be a test for this. Phil> + is_py_none = print_string_repr (printer, hint, stream, recurse, options, language, Phil> + gdbarch); Phil> + print_children (printer, hint, stream, recurse, options, language, is_py_none); These lines look like they wrap now. Tom