From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1204 invoked by alias); 23 Apr 2010 22:34:54 -0000 Received: (qmail 1195 invoked by uid 22791); 23 Apr 2010 22:34:53 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Apr 2010 22:34:49 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3NMYlmp015308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 23 Apr 2010 18:34:47 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3NMYk9p002572; Fri, 23 Apr 2010 18:34:46 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3NMYjY2009451; Fri, 23 Apr 2010 18:34:46 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 6C97737849C; Fri, 23 Apr 2010 16:34:45 -0600 (MDT) From: Tom Tromey To: Sami Wagiaalla Cc: GDB Patches Subject: Re: [patch] support argument dependent lookup (ADL) References: <4BA7D08C.5070702@redhat.com> <1270829129.2387.23.camel@localhost> Reply-To: tromey@redhat.com Date: Fri, 23 Apr 2010 22:34:00 -0000 In-Reply-To: <1270829129.2387.23.camel@localhost> (Sami Wagiaalla's message of "Fri, 09 Apr 2010 12:05:29 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00821.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> I have added tests for all of the above situations. Thanks. Sami> 2010-04-09 Sami Wagiaalla Sami> PR C++/7943: Sami> * valops.c (find_overload_match): Handle fsym == NULL case. Sami> Add int no_adl argument. Sami> (find_oload_champ_namespace_loop): Call make_symbol_overload_list_adl [...] This ChangeLog entry and the one in the patch are different. Sami> + write_exp_elt_sym (NULL); /* Place holder */ A nit, "placeholder" is one word. Also, end with a period & double space. Sami> + while (TYPE_CODE (type) == TYPE_CODE_PTR || TYPE_CODE (type) == TYPE_CODE_REF Sami> + || TYPE_CODE (type) == TYPE_CODE_ARRAY) Sami> + type = TYPE_TARGET_TYPE (type); I think you need a check_typedef in the loop. Otherwise in some situations with typedefs I think you can end up with type==NULL. This is ok with those changes. Thanks. Could you submit a followup patch that adds a NEWS entry? Tom