From: Tom Tromey <tromey@redhat.com>
To: Hilfinger@cs.berkeley.edu
Cc: Hilfinger@adacore.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Rework symbol searches to move Ada-specific stuff to ada-lang.c.
Date: Thu, 07 Oct 2010 17:53:00 -0000 [thread overview]
Message-ID: <m3iq1dyjn7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1286424854.1821.2.camel@syracuse.mckusick.com> (Paul Hilfinger's message of "Wed, 06 Oct 2010 21:14:14 -0700")
>>>>> "Paul" == Paul Hilfinger <HIlfinger@cs.berkeley.edu> writes:
Paul> + return (*top);
Tom> A few places have parens here, but they aren't needed.
Tom> Just write "return *top;".
Paul> OK (BTW: That line was copied from the original).
Oh, ok. I had looked to see if this was the case, but I must have
missed it.
My view is that it is always ok to leave code as-is when moving it
around. I recommend pushing back on reviewers who ask for changes to
the context of a patch :-)
Tom
next prev parent reply other threads:[~2010-10-07 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 8:42 Paul Hilfinger
2010-10-06 22:52 ` Tom Tromey
2010-10-07 4:14 ` Paul Hilfinger
2010-10-07 17:53 ` Tom Tromey [this message]
2010-10-07 7:19 ` [commit] " Paul Hilfinger
2010-10-06 23:15 ` [RFA] " Joel Brobecker
2010-10-06 23:49 ` Doug Evans
2010-10-07 4:18 ` Paul Hilfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iq1dyjn7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Hilfinger@adacore.com \
--cc=Hilfinger@cs.berkeley.edu \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox