Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "'gdb-patches\@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [MI] Segfault using 'interpreter-exec mi'
Date: Tue, 07 Dec 2010 21:57:00 -0000	[thread overview]
Message-ID: <m3ipz56ybm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <F7CE05678329534C957159168FA70DEC572E903B97@EUSAACMS0703.eamcs.ericsson.se>	(Marc Khouzam's message of "Tue, 7 Dec 2010 16:38:24 -0500")

>>>>> "Marc" == Marc Khouzam <marc.khouzam@ericsson.com> writes:

Marc> Thanks!
Marc> I was stuck trying to use catch_exception(), which was not working
Marc> because I needed the return value of mi_parse(), but I see that
Marc> using TRY_CATCH was the way to go.

Yeah.  For future reference, you can do that by having a trampoline
function that has different arguments.  I find TRY_CATCH a lot simpler
though.

>> +  if (exception.reason < 0)
>> +    {
>> +      mi_print_exception (token, exception);
>> +      xfree (token);

Marc> Here, do we need an call to
Marc> mi_out_rewind (uiout)?
Marc> I don't know what it does, but I noticed it was being
Marc> called below after mi_print_exception()

It is unclear to me what mi_out_rewind does.
There don't seem to be any comments describing this function.

So, I chose to implement this in a way that is compatible with the
earlier code, which did not call mi_out_rewind on this path.

Tom


  reply	other threads:[~2010-12-07 21:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25 20:54 Marc Khouzam
2010-12-02 16:35 ` Tom Tromey
2010-12-06 21:35   ` Marc Khouzam
2010-12-06 21:41     ` Tom Tromey
2010-12-07 20:32     ` Tom Tromey
2010-12-07 21:08       ` Tom Tromey
2010-12-07 21:39       ` Marc Khouzam
2010-12-07 21:57         ` Tom Tromey [this message]
2010-12-08  1:20           ` Marc Khouzam
2010-12-09 19:15             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ipz56ybm.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox