From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5928 invoked by alias); 15 Dec 2010 07:46:52 -0000 Received: (qmail 5910 invoked by uid 22791); 15 Dec 2010 07:46:51 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Dec 2010 07:46:45 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBF7kP3x023409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Dec 2010 02:46:25 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oBF7kN0p015109; Wed, 15 Dec 2010 02:46:24 -0500 From: Phil Muldoon To: Joel Brobecker Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] Fix fileio.exp failuew when run as root user. References: <20101214065744.GN2596@adacore.com> <201012140955.23411.pedro@codesourcery.com> <20101215051138.GZ2596@adacore.com> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Wed, 15 Dec 2010 07:46:00 -0000 In-Reply-To: <20101215051138.GZ2596@adacore.com> (Joel Brobecker's message of "Wed, 15 Dec 2010 09:11:38 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00285.txt.bz2 Joel Brobecker writes: >> Note that this test is meant to test remote file io capabilities. >> The fact that it runs on a native gdb is merely a way to give it >> a bit more exposure against bitrot. We need to make sure to not >> simply fail the test if the syscalls we're introducing are not supported >> by remote file io (remote-fileio.c), and they fail on the >> target (e.g., ENOSYS), and also that the test still compiles on >> bare metal targets, with e.g., newlib (otherwise, the test becomes >> useless). (The test was probably running on Windows/mingw as well, >> but the "geteuid" call introduction is probably making it not compile >> there anymore.) > > So, as it is, the fix doesn't meet those requirements and shouldn't > be applied, right? If that's the case, then perhaps the first question > is to figure out why someone is running the testsuite as root... Is > that a sysadmin who is building GDB as root? > > I had checked that the new functions used are defined by POSIX, > but confess I never worried about Windows. Sorry. Jan wrote the patch and it was carried with our Fedora RPM patch set, so I am going to surmise it is because of distribution build systems running/testing as root. I'll ping Jan and ask him to comment. Cheers, Phil