From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22448 invoked by alias); 4 Mar 2011 18:37:22 -0000 Received: (qmail 22366 invoked by uid 22791); 4 Mar 2011 18:37:21 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 18:37:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p24Iawhu027906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Mar 2011 13:36:58 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p24Iavlh030177; Fri, 4 Mar 2011 13:36:57 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p24Iaupr023235; Fri, 4 Mar 2011 13:36:56 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id ABCA237967C; Fri, 4 Mar 2011 11:36:54 -0700 (MST) From: Tom Tromey To: Michael Snyder Cc: Tristan Gingold , "gdb-patches\@sourceware.org" , "gcc-patches\@gcc.gnu.org" Subject: Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak. References: <4D70061C.10904@vmware.com> <20110303213008.GY30899@tyan-ft48-01.lab.bos.redhat.com> <4D700F5D.2030109@vmware.com> <807E3430-F4F7-464D-8E8A-527A86BA3D88@adacore.com> <4D712A5F.1040307__35010.4677411311$1299262072$gmane$org@vmware.com> <4D712F12.8050808__11842.7885965959$1299263268$gmane$org@vmware.com> Date: Fri, 04 Mar 2011 18:37:00 -0000 In-Reply-To: <4D712F12.8050808__11842.7885965959$1299263268$gmane$org@vmware.com> (Michael Snyder's message of "Fri, 04 Mar 2011 10:27:30 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00307.txt.bz2 Michael> How come 'xfree' in gdb/utils.c still checks for null? I don't know, but I assume just because nobody has bothered to remove the check. I think we also still have code doing `if (x) xfree (x);', which is kind of doubly wrong :) Tom