From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79747-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29094 invoked by alias); 16 Mar 2011 17:11:31 -0000
Received: (qmail 29045 invoked by uid 22791); 16 Mar 2011 17:11:25 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Mar 2011 17:11:21 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2GHBH94010627	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 16 Mar 2011 13:11:19 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2GGglkt019466;	Wed, 16 Mar 2011 12:42:47 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2GGgkld001667;	Wed, 16 Mar 2011 12:42:46 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 21665378CA4; Wed, 16 Mar 2011 10:42:46 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [python] [patch] Add is_valid to several classes
References: <m3sjun9hp7.fsf@redhat.com>
Date: Wed, 16 Mar 2011 17:32:00 -0000
In-Reply-To: <m3sjun9hp7.fsf@redhat.com> (Phil Muldoon's message of "Wed, 16	Mar 2011 16:02:44 +0000")
Message-ID: <m3ipvj3tkq.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00860.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> @@ -85,6 +110,8 @@ objfpy_get_printers (PyObject *o, void *ignore)
Phil>  {
Phil>    objfile_object *self = (objfile_object *) o;
 
Phil> +  OBJFPY_REQUIRE_VALID (self);

This changes behavior.  It is harmless (but goofy) to get or set the
printers on an invalid Objfile.

So, I think this should not be added.

Phil> @@ -95,6 +122,8 @@ objfpy_set_printers (PyObject *o, PyObject *value, void *ignore)
Phil>    PyObject *tmp;
Phil>    objfile_object *self = (objfile_object *) o;
 
Phil> +  OBJFPY_SET_REQUIRE_VALID (self);

Likewise.

Then you don't need the new macros, either.

The rest looks good to me.

Tom