From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20044 invoked by alias); 28 Mar 2011 08:49:37 -0000 Received: (qmail 20034 invoked by uid 22791); 28 Mar 2011 08:49:36 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Mar 2011 08:49:27 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2S8nQ4N014603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Mar 2011 04:49:26 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2S8nPOd004579; Mon, 28 Mar 2011 04:49:25 -0400 From: Phil Muldoon To: Kevin Pouget Cc: gdb-patches@sourceware.org Subject: Re: [RFC - Python] New ObjFile event References: Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Mon, 28 Mar 2011 08:54:00 -0000 In-Reply-To: (Kevin Pouget's message of "Mon, 28 Mar 2011 04:06:29 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01118.txt.bz2 Kevin Pouget writes: > Hello, > > following this discussion at > http://sourceware.org/ml/gdb/2011-03/msg00136.html, I would like to > suggest a patch for the Python event system. Based on the ''exited", > "cont", ... events, this patch allows a python script to register an > interest to the loading of new object files in the debuggee. GDB > observer "observer_attach_new_objfile" is used to trigger the Python > callback. Just a few nits. I am not a maintainer, so please don't take this as any form of blessing ;) > + py-value.o \ > + py-newobjfileevent.o > > SUBDIR_PYTHON_SRCS = \ > python/python.c \ > @@ -326,7 +327,8 @@ > python/py-threadevent.c \ > python/py-type.c \ > python/py-utils.c \ > - python/py-value.c > + python/py-value.c \ > + python/py-newobjfileevent.c I'm not sure on the status of 8.3 file naming conventions, whether they matter anymore. > +extern struct objfile *gdbpy_current_objfile; > +static void > +python_new_objfile (struct objfile *objfile) > +{ > + struct cleanup *cleanup; > + > + /* Will be NULL when clearing the symtab. */ > + if (objfile) > + cleanup = ensure_python_env (get_objfile_arch (objfile), current_language); > + else > + cleanup = ensure_python_env (get_current_arch (), current_language); > + > + gdbpy_current_objfile = objfile; > + > + if (emit_new_objfile_event (objfile) < 0) > + gdbpy_print_stack (); The emit_new_objfile_event function seems to be missing? > -static struct objfile *gdbpy_current_objfile; > + source_python_script_for_objfile and new_objfile callbacks; it is NULL at > + other times. */ > +/*static*/ struct objfile *gdbpy_current_objfile; I realize this is something you are unsure of, but if you decide to emit 'static' can you remove the comment too. > /* Set the current objfile to OBJFILE and then read STREAM,FILE as > Python code. */ > @@ -1074,6 +1075,7 @@ > gdbpy_initialize_continue_event (); > gdbpy_initialize_exited_event (); > gdbpy_initialize_thread_event (); > + gdbpy_initialize_new_objfile_event() ; Needs a space after event and before the bracket. Cheers Phil