From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: RFC: implement typed DWARF stack
Date: Mon, 16 May 2011 18:09:00 -0000 [thread overview]
Message-ID: <m3iptah607.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201105161550.p4GFo5hk014748@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Mon, 16 May 2011 17:50:05 +0200 (CEST)")
CCing Jakub.
Ulrich> So just to clarify: in the discussion a while back, you said:
Sorry for any confusion. I hope this email will clear it up.
During our discussion I was convinced that DW_OP_shr should generally
use the sign of any explicit type to decide what to do (with a special
case for implicit type). However, Jakub informed me that GCC relied on
'shr' always zero-filling, even for explicit types. So, I changed the
code back. What is now in the tree implements the same semantics that
GCC assumes.
Ulrich> With this latest patch, it is now definitely *not* the case that
Ulrich> DW_OP_shr and DW_OP_shra behave the same on new-style typed
Ulrich> values. Instead, as I pointed out originally, DW_OP_shr now
Ulrich> always performs an unsigned operation, while DW_OP_shra respects
Ulrich> the value's type ...
Ulrich> Is that really what was intended?
At least the shr part is intended. I did not consider the shra case.
Ulrich> Or should rather DW_OP_shra now also be changed (to always
Ulrich> perform a signed operation as its name suggests)?
In other words, mirror the shr special case for shra.
This makes sense to me. Jakub, what do you think?
Tom
next prev parent reply other threads:[~2011-05-16 18:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 20:48 Tom Tromey
2011-05-05 16:47 ` Tom Tromey
2011-05-05 18:07 ` Ulrich Weigand
2011-05-05 18:38 ` Tom Tromey
2011-05-05 20:15 ` Tom Tromey
2011-05-09 22:02 ` Ulrich Weigand
2011-05-10 14:15 ` Tom Tromey
2011-05-11 0:15 ` Ulrich Weigand
2011-05-11 14:59 ` Tom Tromey
2011-05-11 19:44 ` Tom Tromey
2011-05-12 0:03 ` Ulrich Weigand
2011-05-12 16:33 ` Tom Tromey
2011-05-13 7:52 ` Regression: " Jan Kratochvil
2011-05-13 15:44 ` Tom Tromey
2011-05-15 8:26 ` gdbindex crash: " Jan Kratochvil
2011-05-16 17:37 ` Tom Tromey
2011-05-17 17:01 ` Tom Tromey
2011-05-13 17:17 ` Tom Tromey
2011-05-13 17:34 ` Jan Kratochvil
2011-05-12 19:32 ` Tom Tromey
2011-05-16 15:50 ` Ulrich Weigand
2011-05-16 18:09 ` Tom Tromey [this message]
2011-05-17 8:35 ` Jakub Jelinek
2011-06-03 13:52 ` Tom Tromey
2011-05-10 16:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iptah607.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jakub@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox