From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26068 invoked by alias); 23 May 2011 15:15:40 -0000 Received: (qmail 26037 invoked by uid 22791); 23 May 2011 15:15:37 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 15:15:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4NFF5i9003834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 May 2011 11:15:05 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4NFF4nr025071; Mon, 23 May 2011 11:15:04 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4NFF3ub001320; Mon, 23 May 2011 11:15:04 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 9E6AC3791A0; Mon, 23 May 2011 09:15:03 -0600 (MDT) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Really make dwarf2_get_section_info public. References: <1306146544-3925-1-git-send-email-gingold@adacore.com> <1306146544-3925-2-git-send-email-gingold@adacore.com> Date: Mon, 23 May 2011 15:15:00 -0000 In-Reply-To: <1306146544-3925-2-git-send-email-gingold@adacore.com> (Tristan Gingold's message of "Mon, 23 May 2011 12:29:01 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00525.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: Tristan> This patch is a preliminary clean-up. Instead of using the Tristan> section name to get the section info, use an enum literal. Looks reasonable, just one nit. Tristan> It might be worth going farther and using an array of Tristan> dwarf2_section_info in dwarf2_per_objfile (instead of record Tristan> fields). I let this decision to maintainers. I think it is fine as is. Tristan> +enum dwarf2_section_enum { Tristan> + dwarf2_debug_frame, Tristan> + dwarf2_eh_frame Tristan> +}; It is customary for enum constants to be upper-case. Ok with this change. Tom