From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28762 invoked by alias); 12 Aug 2011 22:20:36 -0000 Received: (qmail 28744 invoked by uid 22791); 12 Aug 2011 22:20:33 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Aug 2011 22:20:14 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7CMKEsN007704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 12 Aug 2011 18:20:14 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7CMKCK0015867; Fri, 12 Aug 2011 18:20:12 -0400 From: Phil Muldoon To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [python] [patch] set/show extended-prompt References: Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Fri, 12 Aug 2011 22:20:00 -0000 In-Reply-To: (Tom Tromey's message of "Fri, 12 Aug 2011 14:22:05 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00266.txt.bz2 Tom Tromey writes: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> This patch adds extended-prompt capabilities to GDB. In addition > Phil> it adds a prompt substitution library. I made the extended-prompt > Phil> lazily control the prompt_hook on setting, over controlling it > Phil> unconditionally. The rest of the function remains the same other > Phil> than in-Python documentation as was found in Archer. > > The code bits are ok. I am going to submit another patch with Matt's suggested changes to the escape issue. I expect this will be a formality, but I would prefer an explicit OK with the new changes. > This needs a NEWS entry. Agreed I forgot about the NEWS entry (again). > The doc/ChangeLog entry looks messed up to me. In which way? I generated ChangeLogs with each change in texinfo mode with add-changelog-mode and checked the reference back to the entry. They seem correct? I am not sure what is messed-up? Cheers, Phil