From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12965 invoked by alias); 3 Oct 2011 17:46:27 -0000 Received: (qmail 12942 invoked by uid 22791); 3 Oct 2011 17:46:27 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Oct 2011 17:46:13 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p93HkBDU010977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Oct 2011 13:46:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p93HkBAv024490; Mon, 3 Oct 2011 13:46:11 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p93HkA3C001873; Mon, 3 Oct 2011 13:46:10 -0400 From: Tom Tromey To: logitech Cc: gdb-patches@sourceware.org Subject: Re: Integration of timed breakpoints into GDB References: <32418104.post@talk.nabble.com> Date: Mon, 03 Oct 2011 17:46:00 -0000 In-Reply-To: <32418104.post@talk.nabble.com> (logitech's message of "Wed, 7 Sep 2011 10:42:36 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00031.txt.bz2 >>>>> ">" == logitech writes: >> I have attached a patch file which integrates timed breakpoints into gdb. >> http://old.nabble.com/file/p32418104/patchfile.patch patchfile.patch In addition to the other comments given: >> The format of the command is "break 'x's 'y'us" where 's' and 'us' stand for >> seconds and microseconds respectively. Eg. break 1s 0us I don't think reusing "break" for this is ok. Instead, make a "catch" subcommand. I glanced at the implementation and it has various issues. But I will reserve detailed comment for a resubmission following Keith's comments. Tom