From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4590 invoked by alias); 6 Feb 2012 18:45:24 -0000 Received: (qmail 4581 invoked by uid 22791); 6 Feb 2012 18:45:24 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Feb 2012 18:45:07 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q16Ij6AU025593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Feb 2012 13:45:06 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q16Ij5ts021408; Mon, 6 Feb 2012 13:45:06 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q16Ij3FP000433; Mon, 6 Feb 2012 13:45:04 -0500 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/2] Make names in gdbtypes.h,symtab.h const char *. References: <20120202224938.233881E25BF@ruffy2.mtv.corp.google.com> Date: Mon, 06 Feb 2012 18:45:00 -0000 In-Reply-To: <20120202224938.233881E25BF@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Thu, 2 Feb 2012 14:49:38 -0800 (PST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00059.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> The concept is trivial: Change the name strings in gdbtypes.h,symtab.h Doug> from char * to const char *. Except for a couple of special cases Doug> (documented in gdbtypes.h), all names do not come from malloc space, Doug> and are generally freed with the objfile. Doug> Recording them as const char * is cleaner. I agree that it is cleaner. I skimmed this patch and didn't see anything weird. Tom