From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5730 invoked by alias); 4 Jul 2014 15:35:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5693 invoked by uid 89); 4 Jul 2014 15:35:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 04 Jul 2014 15:35:27 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s64FZMLr006087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 4 Jul 2014 11:35:22 -0400 Received: from psique (ovpn-113-28.phx2.redhat.com [10.3.113.28]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s64FZJ4D001965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 4 Jul 2014 11:35:20 -0400 From: Sergio Durigan Junior To: Gabriel Krisman Bertazi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.fortran/array-element.exp failures. References: <1404453487-20108-1-git-send-email-gabriel@krisman.be> X-URL: http://www.redhat.com Date: Fri, 04 Jul 2014 15:35:00 -0000 In-Reply-To: <1404453487-20108-1-git-send-email-gabriel@krisman.be> (Gabriel Krisman Bertazi's message of "Fri, 4 Jul 2014 02:58:07 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00094.txt.bz2 On Friday, July 04 2014, Gabriel Krisman Bertazi wrote: > This fixes two FAIL results when running this test file due to a > misplaced "continue" command, which caused the inferior to end execution > prematurely. Thanks, this is great :-). > 2014-07-04 Gabriel Krisman Bertazi > > * gdb.fortran/array-element.exp: Remove wrong "continue" command > that caused test to fail. > > --- > gdb/testsuite/gdb.fortran/array-element.exp | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.fortran/array-element.exp b/gdb/testsuite/gdb.fortran/array-element.exp > index 579db03..3c87790 100644 > --- a/gdb/testsuite/gdb.fortran/array-element.exp > +++ b/gdb/testsuite/gdb.fortran/array-element.exp > @@ -41,8 +41,5 @@ gdb_test "continue" \ > "continue to breakpoint" > gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" > > -gdb_test "continue" \ > - "Continuing\\..*Breakpoint.*" \ > - "continue to breakpoint once again" > gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a" I am not a Fortran expert, but after looking at the testcase it seems this is the right fix indeed. BTW, I recommend that this testcase be simplified. Instead of: set bp_location [gdb_get_line_number "continue"] gdb_test "break $bp_location" \ "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \ "breakpoint at continue" gdb_test "continue" \ "Continuing\\..*Breakpoint.*" \ "continue to breakpoint" gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a" It could be written as: gdb_breakpoint [gdb_get_line_number "continue"] gdb_continue_to_breakpoint "continue" gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a" gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a" Would you like to do that? Otherwise, it looks good to me (this is not an approval). Thanks, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/