From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84399 invoked by alias); 23 Mar 2016 15:25:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84278 invoked by uid 89); 23 Mar 2016 15:25:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*o:Research, taste, ko, marcin X-HELO: e06smtp05.uk.ibm.com Received: from e06smtp05.uk.ibm.com (HELO e06smtp05.uk.ibm.com) (195.75.94.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 23 Mar 2016 15:25:44 +0000 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 Mar 2016 15:25:41 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 23 Mar 2016 15:25:38 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 37FAC1B08070 for ; Wed, 23 Mar 2016 15:26:10 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2NFPboY2097494 for ; Wed, 23 Mar 2016 15:25:38 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2NFPa4n006741 for ; Wed, 23 Mar 2016 09:25:37 -0600 Received: from oc1027705133.ibm.com (dyn-9-152-212-180.boeblingen.de.ibm.com [9.152.212.180]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2NFPZqW006732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Mar 2016 09:25:36 -0600 From: Andreas Arnez To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org, Keith Seitz , Ulrich Weigand Subject: Re: [PATCH v4] gdbserver/s390: Switch on tracepoint support. References: <1457087959-3032-1-git-send-email-koriakin@0x04.net> <1458067311-12459-1-git-send-email-koriakin@0x04.net> Date: Wed, 23 Mar 2016 15:25:00 -0000 In-Reply-To: <1458067311-12459-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Tue, 15 Mar 2016 19:41:51 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16032315-0021-0000-0000-000008DE18ED X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00471.txt.bz2 On Tue, Mar 15 2016, Marcin Ko=C5=9Bcielnicki wrote: > Also adds s390 support to gdb.trace testsuite. > > gdb/gdbserver/ChangeLog: > > * linux-s390-low.c (s390_supports_tracepoints): New function. > (struct linux_target_ops): Fill supports_tracepoints hook. > > gdb/testsuite/ChangeLog: > > * gdb.trace/ftrace.exp: Set arg0exp for s390. > * gdb.trace/mi-trace-frame-collected.exp: Expect 4 registers on s390. > * gdb.trace/mi-trace-unavailable.exp: Set pcnum for s390, add gpr0num > variable for GPR 0 instead of assuming it is register 0. > * gdb.trace/trace-common.h: Add s390 fast tracepoint placeholder. > * lib/trace-support.exp: Add s390 registers. > --- > This fixes a minor conflict with the powerpc regular tracepoint support > pushed in the meantime (mi-trace-unavailable.exp now needs gpr0num in > powerpc branch). Please also document this new feature in the NEWS file. [...] > diff --git a/gdb/testsuite/lib/trace-support.exp b/gdb/testsuite/lib/trac= e-support.exp > index 372a595..b307f3f 100644 > --- a/gdb/testsuite/lib/trace-support.exp > +++ b/gdb/testsuite/lib/trace-support.exp > @@ -40,6 +40,10 @@ if [is_amd64_regs_target] { > set fpreg "r31" > set spreg "r1" > set pcreg "pc" > +} elseif { [istarget "s390*-*-*"] } { > + set fpreg "r11" > + set spreg "r15" > + set pcreg "pc" > } else { > set fpreg "fp" > set spreg "sp" Without having looked into the details I wonder why we can't use the default, fp, sp, and pc. Also, I'd slightly prefer initializing these variables with their default values first and then adjusting them per target as required. (This is just a matter of taste.) Otherwise the patch looks good to me. But I think a global- or testsuite-maintainer should approve the changes to the testsuite. Thanks, Andreas