From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109656 invoked by alias); 13 Jun 2017 12:10:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109624 invoked by uid 89); 13 Jun 2017 12:10:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Hx-languages-length:746 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 12:10:11 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5DC8pis111911 for ; Tue, 13 Jun 2017 08:10:14 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 2b2btvqkxa-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 13 Jun 2017 08:10:13 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Jun 2017 13:10:10 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 13 Jun 2017 13:10:08 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v5DCA7kS42729586; Tue, 13 Jun 2017 12:10:07 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F01EFAE058; Tue, 13 Jun 2017 13:07:28 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D41FAAE05F; Tue, 13 Jun 2017 13:07:28 +0100 (BST) Received: from oc1027705133.ibm.com (unknown [9.152.212.151]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 13 Jun 2017 13:07:28 +0100 (BST) From: Andreas Arnez To: Simon Marchi Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH v2 14/19] read/write_pieced_value: Improve logic for buffer allocation References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-15-git-send-email-arnez@linux.vnet.ibm.com> <6078d216d5112c69d697f7e7a1c53012@polymtl.ca> Date: Tue, 13 Jun 2017 12:10:00 -0000 In-Reply-To: <6078d216d5112c69d697f7e7a1c53012@polymtl.ca> (Simon Marchi's message of "Mon, 12 Jun 2017 21:40:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17061312-0040-0000-0000-000003C8C739 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061312-0041-0000-0000-00002061AC44 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-13_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706130215 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00377.txt.bz2 On Mon, Jun 12 2017, Simon Marchi wrote: > On 2017-05-09 19:46, Andreas Arnez wrote: >> @@ -2045,21 +2022,44 @@ write_pieced_value (struct value *to, struct >> value *from) >> } >> break; >> case DWARF_VALUE_MEMORY: [...] > + this_size = bits_to_bytes (dest_offset_bits, this_size_bits); >> + buffer.reserve (this_size); > > Reading Pedro's patch about byte_vector: > > https://sourceware.org/ml/gdb-patches/2017-06/msg00339.html > > reminded me of this, when I read the patch I didn't think it was a > problem. I think this should use resize instead of reserve. OK, I'll wait for Pedro's patch to go in and then push the series with that change. -- Andreas