Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Richard.Earnshaw@arm.com
Cc: gdb-patches@sources.redhat.com, binutils@sources.redhat.com
Subject: Re: RFA: Skip ARM ELF Mapping symbols when showing disassembly
Date: Tue, 20 Jan 2004 13:23:00 -0000	[thread overview]
Message-ID: <m3hdyqycre.fsf@redhat.com> (raw)
In-Reply-To: <20040114234206.GA7504@nevyn.them.org> (Daniel Jacobowitz's message of "Wed, 14 Jan 2004 18:42:06 -0500")

Hi Guys,

> Daniel Jacobowitz <drow@mvista.com> writes:

>> I wonder whether a better way to handle all this is to override 
>> slurp_symbol_table for arm-elf to a routine that just skips the mapping 
>> symbols entirely (or at least, doesn't put them into the list that it 
>> passes back to its caller), then to add a separate function to slurp the 
>> mapping symbols independently.  Then gdb and the disassembler (and the 
>> linker error reports) would all just work normally.
>> 
>> It would be necessary to add support for copying and fixing up the mapping 
>> symbols when linking, but that's probably not too hard.
>
> Actually, I think it's not necessary, since elf_link_input_bfd doesn't
> use the slurp routines anyway - it parses the ELF symbol table
> directly.  In testing it appears to work.
>
> There is another problem, though.  The symbols are in the symbol table
> and thus have assigned numbers.  The returned list of symbols is passed
> back to functions like bfd_canonicalize_reloc, which use the list of
> symbols to resolve relocations.  Probably other consumers assume the
> whole list of ELF symbols is returned, also, and index it by other
> copies of the symbol index.  So the linker doesn't appear to care, but
> objdump and possibly GDB do.
>
> Any ideas on how to resolve this?  We can't NULL out the mapping
> symbols in symptrs either, because the list is defined to be
> NULL-terminated (even though we return its length...).

How about providing a new BFD function which allows the caller to
determine if a symbol should be ignored ?  This function would call
through to an architecture specific backend routine if necessary,
although a generic routine which never ignored any symbols would be
the default.

We might even generalise the function to take a third argument (apart
from the bfd and the symbol) which is a bit-field defining the proposed
purpose(s) for the symbol and then have the function determine if it
is suitable.  ie something like this:

  enum { not_suitable; partially_suitable; fully_suitable } bfd_suitability;

  #define bfd_purpose_display (1 << 0)  /* Should the symbol be shown to the user ?  */
  #define bfd_purpose_resolve (1 << 1)  /* Should the symbol be used for resolving relocs ?  */
  
  extern bfd_suitability
  bfd_symbol_suits_purpose (bfd *         the_bfd,
                            bfd_symbol *  the_symbol,
                            unsigned      the_purposes);

Cheers
        Nick


  reply	other threads:[~2004-01-20 13:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-13 14:29 Nick Clifton
2003-11-13 14:45 ` Richard Earnshaw
2003-11-13 15:20   ` Daniel Jacobowitz
2004-01-14 23:42   ` Daniel Jacobowitz
2004-01-20 13:23     ` Nick Clifton [this message]
2003-11-18 16:15 ` Andrew Cagney
2003-11-18 16:45   ` Richard Earnshaw
2003-11-18 17:20     ` Andrew Cagney
2003-11-18 17:29       ` Richard Earnshaw
2003-11-18 17:41         ` Andrew Cagney
2003-11-18 19:55   ` Nick Clifton
2003-11-25 12:25   ` Nick Clifton
2003-11-25 12:34     ` Richard Earnshaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hdyqycre.fsf@redhat.com \
    --to=nickc@redhat.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=binutils@sources.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox