From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28780 invoked by alias); 5 Dec 2006 20:00:11 -0000 Received: (qmail 28752 invoked by uid 22791); 5 Dec 2006 20:00:07 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Dec 2006 20:00:01 +0000 Received: (qmail 29388 invoked from network); 5 Dec 2006 20:00:00 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Dec 2006 20:00:00 -0000 To: bjgnu@sunnorth.com.cn Cc: gdb-patches@sourceware.org, qinwei@sunnorth.com.cn Subject: Re: [patch] add target Score to GDB References: From: Jim Blandy Date: Tue, 05 Dec 2006 20:00:00 -0000 In-Reply-To: (bjgnu@sunnorth.com.cn's message of "Tue, 5 Dec 2006 10:17:21 +0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00031.txt.bz2 bjgnu@sunnorth.com.cn writes: > I'v ported GDB-6.5.90 to Score target and SunNorth has assigned the forms > to the FSF. > The following is a patch adding Score target to GDB and i hope i could be > the Score maintainer. > I'v posted the patch to gdb@sourceware.org on 2006.12.4, but get no reply, > maybe it's a wrong place. > Could anyone help me checking my patch? I really appreciate your help. > I've checkout the current-cvs and all testpatterns run pass in DejaGNU. > Some FAILs are target dependent. I've checked these FAILs and they are not > gdb bug. > I hope Score target can be added to GDB-6.6 if possible. Hi, Qinwei. gdb-patches is the right mailing list for this. However, it may take us a while to review patches; there aren't very many reviewers. If you don't get a response within a week, then please post a 'ping' patch. Your work is more likely to be reviewed if you post it as a multi-file patch which can be applied by running 'patch -p0 < foo.patch' in the top-level source directory. Unified diffs (diff -u) seem to be the preferred format. Your embed.mt file says: OOLIB_PATH=../../sim_lib/oolib_install TDEPFILES= score-tdep.o SIM_OBS= remote-sim.o TM_CLIBS = -L $(OOLIB_PATH)/lib -lsc_gdb -lsc_tools -lsc_sim -lsc_ice -lprobe -lscore -lsocshell -lsoc -lpackages -lstdc++ -lSDL -lSDL_image SIM= ../sim/score/libsim.a It looks to me as if this means that the 'score' target depends on a simulator located outside the GDB tree. Is this simulator Free software? Please make sure your GDB satisfies the license conditions explained in the COPYING file. If you can release the simulator as Free software as well, that would be best. Otherwise, you may be able to satisfy the license simply by building GDB without the simulator. It seems the simulator in your post is just a stub. We would rather not have stub code in GDB. I don't see a patch to 'sim/configure.in' in your post. 'sim/configure' is generated automatically from configure.in using autoconf. Patches should generally not include changes to generated files, like 'configure', because they can be large. I have some comments on score-tdep.c, but let's get the above issues sorted out first. Finally, I don't know how Joel Brobecker, our release manager, feels about including new ports this late in the process. On the one hand, if the port is self-contained, it is unlikely to break other code. On the other hand, we have already produced our first release candidate. I'll leave the decision to him. Thanks for posting this port!