From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3177 invoked by alias); 24 Aug 2008 20:29:49 -0000 Received: (qmail 3167 invoked by uid 22791); 24 Aug 2008 20:29:49 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 24 Aug 2008 20:29:14 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m7OKSbZi013717 for ; Sun, 24 Aug 2008 16:28:57 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m7OKSQ6R001477 for ; Sun, 24 Aug 2008 16:28:26 -0400 Received: from opsy.redhat.com (vpn-10-23.bos.redhat.com [10.16.10.23]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m7OKSKn4011273; Sun, 24 Aug 2008 16:28:20 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 39EB837831C; Sun, 24 Aug 2008 14:28:30 -0600 (MDT) To: gdb-patches@sourceware.org Subject: Re: [commit] Remove frame_func_unwind References: <20080715183655.GA29872@caradoc.them.org> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Sun, 24 Aug 2008 20:29:00 -0000 In-Reply-To: <20080715183655.GA29872@caradoc.them.org> (Daniel Jacobowitz's message of "Tue\, 15 Jul 2008 14\:36\:55 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00601.txt.bz2 >>>>> "Daniel" =3D=3D Daniel Jacobowitz writes: Daniel> A number of frame unwind functions are no longer necessary now that Daniel> unwinders get the current frame. This patch removes Daniel> frame_func_unwind; tested on x86_64-linux and committed. Just today I found that this makes --enable-targets=3Dall fail to build on my x86 F8 box. m88k-tdep.c uses frame_func_unwind, plus a few other missing things. Error messages appended. For the time being I just removed m88k-tdep.o from ALL_TARGET_OBS. Tom ../../src/gdb/m88k-tdep.c: In function =E2=80=98m88k_frame_cache=E2=80=99: ../../src/gdb/m88k-tdep.c:660: warning: implicit declaration of function = =E2=80=98frame_func_unwind=E2=80=99 ../../src/gdb/m88k-tdep.c: In function =E2=80=98m88k_frame_prev_register=E2= =80=99: ../../src/gdb/m88k-tdep.c:731: error: too many arguments to function =E2=80= =98trad_frame_get_prev_register=E2=80=99 ../../src/gdb/m88k-tdep.c:748: error: too many arguments to function =E2=80= =98trad_frame_get_prev_register=E2=80=99 ../../src/gdb/m88k-tdep.c: At top level: ../../src/gdb/m88k-tdep.c:756: warning: initialization from incompatible po= inter type ../../src/gdb/m88k-tdep.c: In function =E2=80=98m88k_gdbarch_init=E2=80=99: ../../src/gdb/m88k-tdep.c:866: warning: implicit declaration of function = =E2=80=98set_gdbarch_unwind_dummy_id=E2=80=99 ../../src/gdb/m88k-tdep.c:877: warning: implicit declaration of function = =E2=80=98frame_unwind_append_sniffer=E2=80=99