From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10034 invoked by alias); 2 Feb 2009 18:30:20 -0000 Received: (qmail 10026 invoked by uid 22791); 2 Feb 2009 18:30:20 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_56,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Feb 2009 18:30:15 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n12IS52I030173; Mon, 2 Feb 2009 13:28:05 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n12IS4Lw020391; Mon, 2 Feb 2009 13:28:05 -0500 Received: from opsy.redhat.com (vpn-12-182.rdu.redhat.com [10.11.12.182]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n12IS4Na016639; Mon, 2 Feb 2009 13:28:04 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 9357050826F; Mon, 2 Feb 2009 11:28:02 -0700 (MST) To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [RFA][python] Fixes for existing Python code. References: <1233579973.7000.8.camel@localhost.localdomain> From: Tom Tromey Reply-To: tromey@redhat.com Date: Mon, 02 Feb 2009 18:30:00 -0000 In-Reply-To: <1233579973.7000.8.camel@localhost.localdomain> (Thiago Jung Bauermann's message of "Mon\, 02 Feb 2009 11\:06\:12 -0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00032.txt.bz2 >>>>> "Thiago" == Thiago Jung Bauermann writes: Thiago> I'd also like to remind that the following patches for Python support Thiago> are still pending: Thiago> http://sourceware.org/ml/gdb-patches/2009-01/msg00016.html This one is the patch to add more methods to Value. I have two comments on it. First, in convert_value_from_python, I see: - return NULL; + { + PyErr_Clear (); + error (_("Error converting Python value.")); + } This should call gdbpy_print_stack instead of PyErr_Clear. I think we have -- or should have -- a general rule that we call gdbpy_print_stack when "converting" a Python exception to a gdb exception. Using this lets the user control whether stack traces are printed for Python errors, which is handy for debugging Python code. My other comment is just to make sure that all of Eli's documentation comments have been addressed. The patch is ok with the above change. Thiago> http://sourceware.org/ml/gdb-patches/2009-01/msg00003.html This is the patch to add la_getstr. I'll reply to it separately. Thiago> http://sourceware.org/ml/gdb-patches/2009-01/msg00004.html This adds Value.string, using la_getstr. This patch is ok once the la_getstr code goes in, and provided that Eli oks the documentation. Tom