From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23229 invoked by alias); 24 Apr 2009 15:33:08 -0000 Received: (qmail 23212 invoked by uid 22791); 24 Apr 2009 15:33:04 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Apr 2009 15:32:57 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3OFWW1m019130; Fri, 24 Apr 2009 11:32:32 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3OFWV14012934; Fri, 24 Apr 2009 11:32:31 -0400 Received: from opsy.redhat.com (vpn-12-101.rdu.redhat.com [10.11.12.101]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3OFWUbq021441; Fri, 24 Apr 2009 11:32:31 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 15253C881B1; Fri, 24 Apr 2009 09:32:30 -0600 (MDT) To: Caz Yokoyama Cc: "'Joel Brobecker'" , Subject: Re: symbolic debug of loadable modules with kgdb light References: From: Tom Tromey Reply-To: tromey@redhat.com Date: Fri, 24 Apr 2009 15:33:00 -0000 In-Reply-To: (Caz Yokoyama's message of "Fri\, 9 Jan 2009 07\:51\:04 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00695.txt.bz2 >>>>> "Caz" == Caz Yokoyama writes: Caz> I have attached the patch against gdb-6.8. Thanks. Caz> - This patch is based on Caz> http://kgdb.cvs.sourceforge.net/viewvc/kgdb/gdb/. I removed Caz> garbage as mush as possible. But it still has the code which I Caz> don't know what it is. I don't remove copyright notice which is Caz> there. Do you have copyright assignment papers on file with the FSF? If not, let me know and I can get you started on the process. This is a requirement for getting any code into gdb. Did you write this entire patch yourself? I just want to make sure. If not, we'll need to get papers from any contributor who wrote more than 10 lines of code in the patch. Caz> - I haven't run testsuite because I could not find how to do that while I Caz> run make in testsuite directory. "make check". You need dejagnu installed. And you actually have to run a baseline check without your patch applied, then compare the results. Caz> - I believe that the code follows coding standard. Let me know if Caz> not. I noticed a number of formatting nits. These are no big deal. More importantly, the patch makes a bunch of apparently kernel-debugging-specific changes to generic code. I did not try to read it very closely, but basically all of these will need to be cleaned up. Some of the hunks we definitely do not want; e.g., moving struct value into value.h. Tom