From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32749 invoked by alias); 25 Apr 2009 22:41:25 -0000 Received: (qmail 32738 invoked by uid 22791); 25 Apr 2009 22:41:24 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_13,J_CHICKENPOX_23,J_CHICKENPOX_27,J_CHICKENPOX_63,J_CHICKENPOX_92,J_CHICKENPOX_93,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 25 Apr 2009 22:41:21 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id n3PMf8p4032683; Sat, 25 Apr 2009 15:41:08 -0700 Received: from smtp.corp.google.com (spacemonkey1.corp.google.com [192.168.120.115]) by wpaz33.hot.corp.google.com with ESMTP id n3PMf551020386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 25 Apr 2009 15:41:06 -0700 Received: from localhost.localdomain.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net [71.133.8.30]) (authenticated bits=0) by smtp.corp.google.com (8.13.8/8.13.8) with ESMTP id n3PMf42Q028003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 25 Apr 2009 15:41:04 -0700 To: Eli Zaretskii Cc: joseph@codesourcery.com, gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com Subject: Re: needed-list fails in libiberty References: <83vdp7mile.fsf@gnu.org> <83r5zvmh5v.fsf@gnu.org> <837i1mmiyh.fsf@gnu.org> <8363h4lcc3.fsf@gnu.org> <83iqktf427.fsf@gnu.org> From: Ian Lance Taylor Date: Sat, 25 Apr 2009 22:41:00 -0000 In-Reply-To: <83iqktf427.fsf@gnu.org> (Eli Zaretskii's message of "Sat\, 25 Apr 2009 12\:58\:08 +0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00711.txt.bz2 This patch has already been approved, but I gather that Eli does not have write access to the repository. Does anybody want to volunteer to commit it? Ian Eli Zaretskii writes: >> Date: Thu, 16 Apr 2009 20:47:56 +0300 >> From: Eli Zaretskii >> Cc: joseph@codesourcery.com, gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com > > Ping. > >> > Cc: joseph@codesourcery.com, gcc-patches@gcc.gnu.org, >> > gdb-patches@sources.redhat.com >> > From: Ian Lance Taylor >> > Date: Wed, 15 Apr 2009 06:49:48 -0700 >> > >> > Eli Zaretskii writes: >> > >> > >> > 2009-04-14 Eli Zaretskii >> > >> > >> > >> > * Makefile.in (needed-list): Target removed (not used in GCC >> > >> > 3.0 and later). All references deleted. >> > >> >> > >> This is OK if you've done a clean bootstrap on a primary platform. >> >> I bootstrapped yesterday's SVN on this platform: >> >> Linux fencepost 2.6.16.29-xen #1 SMP Wed Dec 6 07:32:36 EST 2006 x86_64 GNU/Linux >> >> > For a patch like this only the libiberty testsuite need be run. >> >> After a successful bootstrap, I typed "make -C libiberty check", and >> the test ran to completion without any errors. >> >> Here's again the patch I suggest (this time including the removal of 2 >> obsolete Awk scripts). As I don't have write access, could someone >> please commit it? >> >> Thanks. >> >> 2009-04-16 Eli Zaretskii >> >> * Makefile.in (needed-list): Target removed (not used in GCC >> 3.0 and later). All references deleted. >> (mostlyclean): Remove references to needed.awk and needed2.awk. >> >> >> --- libiberty/Makefile.in~ 2009-04-15 14:07:06.825412329 -0400 >> +++ libiberty/Makefile.in 2009-04-15 15:15:03.574853288 -0400 >> @@ -100,7 +100,7 @@ >> SUBDIRS = testsuite >> >> # FIXME: add @BUILD_INFO@ once we're sure it works for everyone. >> -all: stamp-picdir $(TARGETLIB) needed-list required-list all-subdir >> +all: stamp-picdir $(TARGETLIB) required-list all-subdir >> @: $(MAKE) ; exec $(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=all >> >> .PHONY: check installcheck >> @@ -377,22 +377,6 @@ >> mv -f $(DESTDIR)$(tooldir)/lib/$(MULTIOSDIR)/$(TARGETLIB)n $(DESTDIR)$(tooldir)/lib/$(MULTIOSDIR)/$(TARGETLIB) >> @$(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=install >> >> -# needed-list is used by libstdc++. NEEDED is the list of functions >> -# to include there. Do not add anything LGPL to this list; libstdc++ >> -# can't use anything encumbering. >> -NEEDED = atexit calloc memchr memcmp memcpy memmove memset rename strchr \ >> - strerror strncmp strrchr strstr strtol strtoul tmpnam vfprintf vprintf \ >> - vfork waitpid bcmp bcopy bzero >> -needed-list: Makefile >> - rm -f needed-list; touch needed-list; \ >> - for f in $(NEEDED); do \ >> - for g in $(LIBOBJS) $(EXTRA_OFILES); do \ >> - case "$$g" in \ >> - *$$f*) echo $$g >> needed-list ;; \ >> - esac; \ >> - done; \ >> - done >> - >> # required-list was used when building a shared bfd/opcodes/libiberty >> # library. I don't know if it used by anything currently. >> required-list: Makefile >> @@ -440,8 +424,8 @@ >> # multiple times, hence our explicit recursion with an empty SUBDIRS. >> mostlyclean: mostlyclean-subdir >> -rm -rf *.o pic core errs \#* *.E a.out >> - -rm -f needed.awk needed2.awk errors dummy needed-list config.h stamp-* >> - -rm -f $(CONFIG_H) $(NEEDED_LIST) stamp-picdir >> + -rm -f errors dummy config.h stamp-* >> + -rm -f $(CONFIG_H) stamp-picdir >> -rm -f libiberty.aux libiberty.cp libiberty.cps libiberty.fn libiberty.ky >> -rm -f libiberty.log libiberty.tmp libiberty.tps libiberty.pg >> -rm -f libiberty.pgs libiberty.toc libiberty.tp libiberty.tpl libiberty.vr >>