From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21214 invoked by alias); 11 Dec 2009 19:21:11 -0000 Received: (qmail 21201 invoked by uid 22791); 11 Dec 2009 19:21:11 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Dec 2009 19:21:07 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBBJKhf9006071 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 Dec 2009 14:20:44 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBBJKhX4022305; Fri, 11 Dec 2009 14:20:43 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBBJKgbn009145; Fri, 11 Dec 2009 14:20:42 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 357AA3782A3; Fri, 11 Dec 2009 12:20:42 -0700 (MST) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches ml Subject: Re: [RFA] Move buildid stuff from symfile.c to elfread.c References: <81FAA351-3C2E-4023-B373-5078D9D66A4A@adacore.com> Reply-To: tromey@redhat.com Date: Fri, 11 Dec 2009 19:21:00 -0000 In-Reply-To: <81FAA351-3C2E-4023-B373-5078D9D66A4A@adacore.com> (Tristan Gingold's message of "Fri, 11 Dec 2009 11:41:14 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00167.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: Tristan> I have also added a new function, protocol_bfd_open to make Tristan> common an idiom used 3 times. I haven't found a better name Tristan> but suggrestions are very welcome. Andreas' suggestion seems good to me. Tristan> +/* If NAME is a remote name open the file using remote protocol, otherwise Tristan> + open it normaly. */ Typo, should be "normally". This is ok with the typo fix and the rename. Thanks. Tom