From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 943 invoked by alias); 23 Feb 2010 23:55:11 -0000 Received: (qmail 929 invoked by uid 22791); 23 Feb 2010 23:55:10 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Feb 2010 23:55:05 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1NNsXZg011471 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Feb 2010 18:54:33 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1NNsWeH015162; Tue, 23 Feb 2010 18:54:32 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1NNsV1J010301; Tue, 23 Feb 2010 18:54:31 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id C38F63780ED; Tue, 23 Feb 2010 16:54:30 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: Vladimir Prus , Joel Brobecker , gdb-patches@sourceware.org, Chris Moller Subject: Re: pr 11067 patch References: <20100212041137.GE2907@adacore.com> <4B75783D.6050103@redhat.com> <20100213114933.GA595@host0.dyn.jankratochvil.net> <4B76F5CE.30704@redhat.com> <20100219142846.GC2779@adacore.com> <20100219143609.GA1210@host0.dyn.jankratochvil.net> <4B7EA5F9.6030001@redhat.com> <20100219185004.GA23504@host0.dyn.jankratochvil.net> <4B7EEBC8.7060206@redhat.com> <20100219201105.GA30692@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Tue, 23 Feb 2010 23:55:00 -0000 In-Reply-To: <20100219201105.GA30692@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Fri, 19 Feb 2010 21:11:05 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00580.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Finally catching up on this thread... Jan> I would prefer the value_print_options way but rather: Yes, I think value_print_options is preferable to checking ui_out_is_mi_like_p. My reason is that getting the ui-out object involves looking at some global state, whereas value_print_options is local to the call hierarchy. This means that it is simpler to reason about and modify. Tom