From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] More linespec quoting "fixes"
Date: Fri, 26 Feb 2010 23:02:00 -0000 [thread overview]
Message-ID: <m3hbp3mwh2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B85A3BF.8010001@redhat.com> (Keith Seitz's message of "Wed, 24 Feb 2010 14:10:07 -0800")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Daniel recently committed a patch which fixed a couple of
Keith> linespec inconsistencies (allow "file:'function'" and
Keith> "'file:function'").
Keith> I wonder why not also allow "'file':function" and
Keith> "'file':'function'"?
Keith> I couldn't find a good answer as to why these two forms would be
Keith> disallowed, so I'm submitting the attached patch to enable these
Keith> formats.
The patch seems reasonable enough to me. But, I don't claim to
understand linespec.c, so I'd appreciate it if someone else would take a
look.
My real question is whether we want to do this. We've talked a little
bit about rewriting linespec to be less horrible... will supporting more
syntax make this too hard? I'm open to breaking compatibility a bit --
but I think there is a limit to what we can do there, based on what is
documented.
Tom
next prev parent reply other threads:[~2010-02-26 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 22:10 Keith Seitz
2010-02-24 22:49 ` Keith Seitz
2010-02-26 23:02 ` Tom Tromey [this message]
2010-03-03 18:00 ` Keith Seitz
2010-03-04 13:51 ` Daniel Jacobowitz
2010-03-04 18:39 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hbp3mwh2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox