Re: [PATCH v2] sim: use socklen_t with accept()

Mike Frysinger
2010-03-30T22:39:36Z

[-- Attachment #1: Type: Text/Plain, Size: 1282 bytes --]

On Tuesday 30 March 2010 18:21:55 Tom Tromey wrote:
> >>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
> Mike> 2010-03-30 Mike Frysinger <vapier@gentoo.org>
> Mike> * configure.ac: Check for socklen_t.
> Mike> * configure, config.in: Regenerated.
> Mike> * dv-sockser.c (connected_p): Change addrlen type to socklen_t.
>
> Somewhere, probably dv-sockser.c, you also need this bit:
>
> #ifndef HAVE_SOCKLEN_T
> typedef int socklen_t;
> #endif

i would have thought the configure code people were using would take care of
this, but oh well.

> Mike> Note: this config.in diffstat is larger because the regen tweaked the
> Mike> comment style for a lot of defines ... not sure if this is
> correct
>
> Make sure you use the exact same versions of the autotools as currently
> used in the tree. I download the canonical versions from gnu.org and
> install them all in a fresh $prefix for gdb hacking. You can't use
> different versions (even minor versions) or distro variants, as they
> cause churn in the repository.

right, trying to do otherwise gave me an error about wanting exactly 2.64. so
i installed that version but still saw the churn. i'll include the changes in
the next patch so you can see what i mean.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]