From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2671 invoked by alias); 21 Apr 2010 01:07:49 -0000 Received: (qmail 2660 invoked by uid 22791); 21 Apr 2010 01:07:48 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 01:07:44 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3L17KbV022901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Apr 2010 21:07:21 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3L17Ksc005945; Tue, 20 Apr 2010 21:07:20 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3L17Jo2030362; Tue, 20 Apr 2010 21:07:19 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B257837979C; Tue, 20 Apr 2010 19:07:18 -0600 (MDT) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/Ada] Wrong value printed by info locals for dynamic object. References: <20100420230318.GV19194@adacore.com> Reply-To: tromey@redhat.com Date: Wed, 21 Apr 2010 01:07:00 -0000 In-Reply-To: <20100420230318.GV19194@adacore.com> (Joel Brobecker's message of "Tue, 20 Apr 2010 19:03:18 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00666.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> return val_print (value_type (val), value_contents_all (val), >> value_embedded_offset (val), value_address (val), >> stream, recurse, options, language); >> Short of creating a language-specific value_contents routine, I think >> that this was the best/easiest compromise... Thoughts on that? I suppose a new language method is also possible. That may be overkill for a single specialization. Joel> Well, stupid me (again!): I just realized that I checked in a couple Joel> of patches for which I said yesterday that I'd wait a few days. Sorry Joel> about that. Hopefully this is not a problem, but I'm happy to revert Joel> and/or adjust based on feedback. My entire week is dedicated to the Joel> FSF tree, so I have time... IMO, don't revert, just address comments if any. I think reverting should generally be reserved for extreme scenarios, say when some fundamental problem is discovered. Tom