From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76080-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27529 invoked by alias); 14 Oct 2010 17:46:37 -0000
Received: (qmail 27517 invoked by uid 22791); 14 Oct 2010 17:46:34 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Oct 2010 17:46:19 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9EHkFrV000879	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 14 Oct 2010 13:46:15 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9EHkFHT028007;	Thu, 14 Oct 2010 13:46:15 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o9EHkE3C012122;	Thu, 14 Oct 2010 13:46:14 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 037163791BC; Thu, 14 Oct 2010 11:46:13 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Doug Evans <dje@google.com>
Subject: Re: [patch] Fix ELF stale reference
References: <20100908185837.GA24606@host1.dyn.jankratochvil.net>	<m3wrqwrplv.fsf@fleche.redhat.com>	<20100909090511.GA937@host1.dyn.jankratochvil.net>	<AANLkTikm4c_dPTiqA8hsw8AkNbpKbyQNxC3qgRJi98Au@mail.gmail.com>	<20100909145615.GA5771@host1.dyn.jankratochvil.net>	<20101014160653.GA24333@host1.dyn.jankratochvil.net>
Date: Thu, 14 Oct 2010 17:46:00 -0000
In-Reply-To: <20101014160653.GA24333@host1.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Thu, 14 Oct 2010 18:06:53 +0200")
Message-ID: <m3hbgo8y6y.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-10/txt/msg00245.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> OK to check-in?  Or some bfd/ API improvement should be made?

I think this is probably the cleanest fix.

However, libbfd.h does say right at the top that it shouldn't be used.

I guess we could ask for advice on the binutils list.
Perhaps we could make bfd_alloc a public function.
Or maybe it is ok to bend this rule.

Tom