From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23429 invoked by alias); 2 May 2011 14:47:08 -0000 Received: (qmail 23396 invoked by uid 22791); 2 May 2011 14:47:06 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 May 2011 14:46:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p42EkiRP019600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 May 2011 10:46:44 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p42EkiC4022195; Mon, 2 May 2011 10:46:44 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p42Ekhu9011029; Mon, 2 May 2011 10:46:43 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 2F75A378334; Mon, 2 May 2011 08:46:43 -0600 (MDT) From: Tom Tromey To: Petr =?utf-8?Q?Hluz=C3=ADn?= Cc: paawan oza , gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] arm reversible : References: <341905.10459.qm@web112513.mail.gq1.yahoo.com> <208397.95006.qm@web112517.mail.gq1.yahoo.com> <4DA27006.1080607@codesourcery.com> <763549.92092.qm@web112506.mail.gq1.yahoo.com> <335149.24692.qm@web112515.mail.gq1.yahoo.com> <592215.58786.qm@web112508.mail.gq1.yahoo.com> <172713.29831.qm@web112503.mail.gq1.yahoo.com> Date: Mon, 02 May 2011 14:47:00 -0000 In-Reply-To: ("Petr =?utf-8?Q?Hluz=C3=ADn=22's?= message of "Sun, 1 May 2011 03:19:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00014.txt.bz2 >>>>> "Petr" =3D=3D Petr Hluz=C3=ADn writes: Petr> I also recommend to define a local variable in the smalles scope Petr> possible, however I understand that many Petr> programmers use weak tools and knowing its definition requires more Petr> effort than placing cursor on the variable - therefore they prefer Petr> definitions at the start of function. I agree, using the smallest scope is generally preferable. This practice makes it simpler to reason about the code. Petr> My IDE has a spellchecker which underlines typos. No effort required. Petr> (Consider upgrading your tools.) I'm curious to know what IDE you use for working on GDB. For those using Emacs, M-x flyspell-prog-mode will spell-check in comments and strings. Petr> Also I have no vote in GDB development, so my patch approval would Petr> have little impact. I appreciate thoughtful reviews from anyone, regardless of their official status. I think GDB patches still spend too much time waiting for review, and this sort of thing can help speed things up. Petr> GDB commiters: please reply whether you agree with my review. (So that Petr> paawan oza does not spend effort in vain.) I thought it was quite good. Thanks for doing this. Tom