From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13996 invoked by alias); 28 Jul 2011 16:40:46 -0000 Received: (qmail 13953 invoked by uid 22791); 28 Jul 2011 16:40:45 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jul 2011 16:40:20 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6SGdnRZ016141 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Jul 2011 12:39:50 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6SGdnhJ005131; Thu, 28 Jul 2011 12:39:49 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6SGdlHH009236; Thu, 28 Jul 2011 12:39:47 -0400 From: Tom Tromey To: Joel Brobecker Cc: iam ahal , gdb-patches@sourceware.org, eliz@gnu.org, pmuldoon@redhat.com, pedro@codesourcery.com, drow@false.org Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) References: <834o33qlm9.fsf@gnu.org> <83bowq6x7f.fsf@gnu.org> <20110728153349.GF5177@adacore.com> Date: Thu, 28 Jul 2011 17:39:00 -0000 In-Reply-To: <20110728153349.GF5177@adacore.com> (Joel Brobecker's message of "Thu, 28 Jul 2011 08:33:49 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00793.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> I think instead of 'strstr' as a test, you want strncmp, followed by a >> check to make sure that either the compilation directory ends with a >> directory separator, or the following character in the source file name >> is one. Joel> Seems like filename_ncmp would be better? Yeah, whoops. Joel> (should we write a specific routine that checks whether a given Joel> fullpath "starts with" a given directory name?) It wouldn't hurt. Tom