From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84107-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18243 invoked by alias); 4 Oct 2011 19:10:56 -0000
Received: (qmail 18235 invoked by uid 22791); 4 Oct 2011 19:10:55 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_05,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Oct 2011 19:10:37 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p94JAXac029890	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 4 Oct 2011 15:10:33 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p94JAW9i030710;	Tue, 4 Oct 2011 15:10:33 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p94JAVJ8016578;	Tue, 4 Oct 2011 15:10:31 -0400
From: Tom Tromey <tromey@redhat.com>
To: Stan Shebs <stan_shebs@mentor.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Collecting strings at tracepoints
References: <4E89D9D9.6050703@mentor.com>
Date: Tue, 04 Oct 2011 19:10:00 -0000
In-Reply-To: <4E89D9D9.6050703@mentor.com> (Stan Shebs's message of "Mon, 03	Oct 2011 08:50:49 -0700")
Message-ID: <m3hb3omv2x.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00110.txt.bz2

>>>>> "Stan" == Stan Shebs <stan_shebs@mentor.com> writes:

Stan> While conceptually simple, we need a new agent bytecode to make this
Stan> work (writing a loop using existing bytecodes doesn't let us check
Stan> that we're running off the edge of valid memory), and a support flag
Stan> so that users get informed if the target doesn't support string
Stan> collection.

Stan> + /* Inspired by trace_kludge, this indicates that pointers to chars
Stan> +    should get an added tracenz bytecode to record nonzero bytes, up to
Stan> +    a length that is the value of string_kludge.  */
Stan> + int string_kludge;

I'd prefer a name that makes it obvious that this is a tracing thing.

Stan> +   { "tracenz", PACKET_DISABLE,
Stan> +     remote_string_tracing_feature, -1 },

I think this requires documentation in the remote protocol section.

Stan> +   while (*exp == ' ' || *exp == '\t')
Stan> +     exp++;

We have skip_spaces now.

Tom