From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16714 invoked by alias); 11 Oct 2011 17:30:34 -0000 Received: (qmail 16695 invoked by uid 22791); 11 Oct 2011 17:30:30 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Oct 2011 17:30:08 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9BHU76w004223 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Oct 2011 13:30:07 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9BGfTx7001262; Tue, 11 Oct 2011 12:41:29 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9BGfR6j021939; Tue, 11 Oct 2011 12:41:28 -0400 From: Tom Tromey To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [patch] [python] Use TRY_CATCH in some functions. References: Date: Tue, 11 Oct 2011 17:30:00 -0000 In-Reply-To: (Phil Muldoon's message of "Tue, 11 Oct 2011 12:57:13 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00314.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> After fixing the bugs related to py-value.c not using TRY_CATCH in some Phil> cases, I decided to take a look at the rest of the Python files. I Phil> caught a few others too. Thanks for doing this. Phil> @@ -624,20 +625,31 @@ typy_lookup_type (struct demangle_component *demangled, [...] Phil> + if (except.reason < 0) Phil> + { Phil> + PyErr_Format (except.reason == RETURN_QUIT Phil> + ? PyExc_KeyboardInterrupt : PyExc_RuntimeError, Phil> + "%s", except.message); Phil> + return NULL; Why not GDB_PY_HANDLE_EXCEPTION here? (And also fix up typy_lookup_typename to do the same.) Phil> @@ -990,8 +1002,16 @@ typy_richcompare (PyObject *self, PyObject *other, int op) [...] Phil> + { Phil> + bcache_xfree (cache); Phil> + VEC_free (type_equality_entry_d, worklist); Phil> + GDB_PY_HANDLE_EXCEPTION (except); I think the freeing should be hoisted above the exception check, to consolidate the code. With the current patch the code is duplicated on both branches. Otherwise this look good. Tom