From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14627 invoked by alias); 9 Nov 2011 19:52:18 -0000 Received: (qmail 14619 invoked by uid 22791); 9 Nov 2011 19:52:18 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Nov 2011 19:52:05 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA9JphPb012881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Nov 2011 14:51:43 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA9Jpghd021500; Wed, 9 Nov 2011 14:51:43 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA9Jpf8L002312; Wed, 9 Nov 2011 14:51:41 -0500 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/procfs] /proc/.../map file descriptor leak References: <1320864439-12456-1-git-send-email-brobecker@adacore.com> <20111109194621.GS14508@adacore.com> Date: Wed, 09 Nov 2011 19:52:00 -0000 In-Reply-To: <20111109194621.GS14508@adacore.com> (Joel Brobecker's message of "Wed, 9 Nov 2011 11:46:21 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00260.txt.bz2 Joel> Argh. The part that changes the checks against zero might be a little Joel> theoretical, and thus have no real effect, but the missing cleanups Joel> are not. We should commit the patch. On solaris, I still cannot run Joel> the testsuite (causing an awful machine crash), but I can run the AdaCore Joel> testsuite. That's better than nothing. Did/could you try the patch? I wrote it just based on reading the code, I can't try it at all. I can resend it if you want. Tom