From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15572 invoked by alias); 2 Dec 2011 18:36:55 -0000 Received: (qmail 15519 invoked by uid 22791); 2 Dec 2011 18:36:53 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Dec 2011 18:36:40 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pB2Iaci5022090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 2 Dec 2011 13:36:38 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pB2Iac5W007116; Fri, 2 Dec 2011 13:36:38 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pB2IaaLX010278; Fri, 2 Dec 2011 13:36:37 -0500 From: Tom Tromey To: oza Pawandeep Cc: Petr =?utf-8?Q?Hluz=C3=ADn?= , paawan oza , "gdb-patches\@sourceware.org" , chandra krishnappa Subject: Re: [PATCH] arm reversible : References: <998639.46560.qm@web112516.mail.gq1.yahoo.com> <321260.58442.qm@web112504.mail.gq1.yahoo.com> <1316327455.23344.YahooMailNeo@web112509.mail.gq1.yahoo.com> <1316404058.27177.YahooMailNeo@web112502.mail.gq1.yahoo.com> <1318650316.91503.YahooMailNeo@web112508.mail.gq1.yahoo.com> Date: Fri, 02 Dec 2011 18:36:00 -0000 In-Reply-To: (oza Pawandeep's message of "Sat, 19 Nov 2011 17:09:13 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00047.txt.bz2 >>>>> "oza" == oza Pawandeep writes: oza> please find the updated patch; I have tried my level best to take care oza> the most to get formatting right. oza> And also, all extra parentheses removed. Thanks. oza> please have a look. (hope mailer does not do anything) Your mailer is still screwed up. You didn't write a ChangeLog entry or a NEWS entry. Please do this. I have asked at least once now. These are just baseline things for getting patches into gdb; if you don't respond to these requests it makes me tend to prioritize other patches over yours. FYI. oza> + /* if this insn has fallen into extension space oza> + then we need not decode it anymore. */ oza> + if (ret != -1 && !INSN_RECORDED(arm_record)) oza> + { oza> + arm_handle_insn[insn_id] (arm_record); Still not checking the return value. oza> +/* cleans up local record registers and memory allocations. */ Should start with a capital letter. Blank line between comment and function. oza> +void deallocate_reg_mem(insn_decode_record *record) Newline after void. Space before open paren. oza> +{ oza> + if (record->arm_regs) oza> + xfree (record->arm_regs); oza> + if (record->arm_mems) oza> + xfree (record->arm_mems); oza> +} You can call xfree on a NULL pointer. Just remove those ifs. oza> + for (no_of_rec = 0; no_of_rec < arm_record.mem_rec_count; oza> no_of_rec++) oza> + { Brace indentation looks wrong. There are still other minor formatting issues. I saw 21 places where there is a comma at the start of a line, please fix all of these. I think there were some other problems, too, but at this point I have stopped caring. Tom