From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86353-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27281 invoked by alias); 20 Dec 2011 15:42:21 -0000
Received: (qmail 27273 invoked by uid 22791); 20 Dec 2011 15:42:20 -0000
X-SWARE-Spam-Status: No, hits=-5.7 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Dec 2011 15:41:59 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBKFfw2U009415	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 20 Dec 2011 10:41:59 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBKFfwr7002003;	Tue, 20 Dec 2011 10:41:58 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pBKFfv0m006079;	Tue, 20 Dec 2011 10:41:57 -0500
From: Tom Tromey <tromey@redhat.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 022/238] [misc.] bcache.c: -Wshadow fix.
References: <CAHQ1cqHNswA2d5dDQsiu3i0kGe6rDFs+izUNYoWcvcf4NaLd0Q@mail.gmail.com>	<1322492788-29388-1-git-send-email-andrew.smirnov@gmail.com>
Date: Tue, 20 Dec 2011 15:42:00 -0000
In-Reply-To: <1322492788-29388-1-git-send-email-andrew.smirnov@gmail.com>	(Andrey Smirnov's message of "Mon, 28 Nov 2011 22:06:25 +0700")
Message-ID: <m3hb0vl06y.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00672.txt.bz2

>>>>> "Andrey" == Andrey Smirnov <andrew.smirnov@gmail.com> writes:

Andrey> 	* bcache.c (expand_hash_table): Rename `bcache' to `cache'(-Wshadow).

Ok.

For the record, I am approving the ones I think are useful.
I still think that the best course is to use -Wshadow in conjunction
with a newer GCC; and to implement configury to check for this GCC
feature.

Tom