From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31872 invoked by alias); 7 Aug 2013 21:02:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31862 invoked by uid 89); 7 Aug 2013 21:02:49 -0000 X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 07 Aug 2013 21:02:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r77L2f2t002664 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Aug 2013 17:02:41 -0400 Received: from psique ([10.3.113.15]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r77L2cYl029547 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 7 Aug 2013 17:02:39 -0400 From: Sergio Durigan Junior To: Doug Evans Cc: GDB Patches , Tom Tromey Subject: Re: [PATCH 7/7] MIPS support References: <1374869594-16965-1-git-send-email-sergiodj@redhat.com> <1374869594-16965-8-git-send-email-sergiodj@redhat.com> X-URL: http://www.redhat.com Date: Wed, 07 Aug 2013 21:02:00 -0000 In-Reply-To: (Doug Evans's message of "Sat, 27 Jul 2013 10:22:19 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00217.txt.bz2 On Saturday, July 27 2013, Doug Evans wrote: > Hi. Just a nit. > > On Fri, Jul 26, 2013 at 1:13 PM, Sergio Durigan Junior > wrote: >> Support for the MIPS target. MIPS already had a definition of >> gdbarch_gdb_signal_from_target, and also an enum containing all signal >> numbers from this target. So, in order to make things standard, I >> removed the previous enum in favor of the new, difference-only enum >> declared by this patch series. And I also redefined the implementation >> of gdbarch_gdb_signal_from_target for MIPS in order to take this new >> enum into account, and only handle the signals which are different from >> the Linux kernel generic ones. >> >> 2013-07-26 Sergio Durigan Junior >> >> * mips-linux-tdep.c: Define enum with differences between >> signals in MIPS and Linux kernel generic ones. >> (mips_gdb_signal_to_target): New function. >> (mips_gdb_signal_from_target): Redefine to use new enum, handle >> only different signals from the Linux kernel generic. >> (mips_linux_init_abi): Set gdbarch_gdb_signal_{to,from}_target >> the functions defined above. >> * mips_gdb_signal_to_target (enum mips_signals): Remove. > > Nit: Fix changelog entry for mips-linux-tdep.h. Done, thanks. -- Sergio