Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <xdje42@gmail.com>
To: gdb-patches@sourceware.org
Subject: Re: New ARI warning Wed Jun  4 01:53:01 UTC 2014
Date: Wed, 04 Jun 2014 03:39:00 -0000	[thread overview]
Message-ID: <m3ha41cphn.fsf@sspiff.org> (raw)
In-Reply-To: <20140604015301.GA17081@sourceware.org> (GDB Administrator's	message of "Wed, 4 Jun 2014 01:53:05 +0000")

GDB Administrator <gdbadmin@sourceware.org> writes:

> 260a261,262
>> gdb/guile/scm-param.c:178: regression: var_boolean: Replace var_boolean with add_setshow_boolean_cmd
> gdb/guile/scm-param.c:178:  p_smob->type = var_boolean;
>> gdb/guile/scm-param.c:852: regression: var_boolean: Replace var_boolean with add_setshow_boolean_cmd
> gdb/guile/scm-param.c:852:  int param_type = var_boolean;

Hi.

I applied this patch.

2014-06-03  Doug Evans  <xdje42@gmail.com>

	* guile/scm-param.c (pascm_make_param_smob): Add ARI comment.
	(gdbscm_make_parameter): Ditto.

diff --git a/gdb/guile/scm-param.c b/gdb/guile/scm-param.c
index ab2efd1..5bfb4ae 100644
--- a/gdb/guile/scm-param.c
+++ b/gdb/guile/scm-param.c
@@ -175,7 +175,7 @@ pascm_make_param_smob (void)
 
   memset (p_smob, 0, sizeof (*p_smob));
   p_smob->cmd_class = no_class;
-  p_smob->type = var_boolean;
+  p_smob->type = var_boolean; /* ARI: var_boolean */
   p_smob->set_func = SCM_BOOL_F;
   p_smob->show_func = SCM_BOOL_F;
   p_scm = scm_new_smob (parameter_smob_tag, (scm_t_bits) p_smob);
@@ -849,7 +849,7 @@ gdbscm_make_parameter (SCM name_scm, SCM rest)
   char *s;
   char *name;
   int cmd_class = no_class;
-  int param_type = var_boolean;
+  int param_type = var_boolean; /* ARI: var_boolean */
   SCM enum_list_scm = SCM_BOOL_F;
   SCM set_func = SCM_BOOL_F, show_func = SCM_BOOL_F;
   char *doc = NULL, *set_doc = NULL, *show_doc = NULL;


      reply	other threads:[~2014-06-04  3:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  1:53 GDB Administrator
2014-06-04  3:39 ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ha41cphn.fsf@sspiff.org \
    --to=xdje42@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox