From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57713 invoked by alias); 10 Aug 2015 16:43:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57703 invoked by uid 89); 10 Aug 2015 16:43:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 10 Aug 2015 16:43:31 +0000 Received: by pacgr6 with SMTP id gr6so30498196pac.2 for ; Mon, 10 Aug 2015 09:43:29 -0700 (PDT) X-Received: by 10.68.242.166 with SMTP id wr6mr44440923pbc.144.1439225009399; Mon, 10 Aug 2015 09:43:29 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id y2sm20531127pdi.80.2015.08.10.09.43.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Aug 2015 09:43:28 -0700 (PDT) From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v6 1/9] Explicit locations: rename "address string"/"addr_string" to "location" References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> <20150805232857.21646.59261.stgit@valrhona.uglyboxes.com> Date: Mon, 10 Aug 2015 16:43:00 -0000 In-Reply-To: <20150805232857.21646.59261.stgit@valrhona.uglyboxes.com> (Keith Seitz's message of "Wed, 05 Aug 2015 16:29:10 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00217.txt.bz2 Keith Seitz writes: > *This patch has previously been approved.* > > This patch renames all occurrances of "addr_string" and "address > string" in the breakpoint/linespec APIs. This will emphasize the > change from address strings used in setting breakpoints (et al) to the > new locations-based API introduced in subsequent patches. > > gdb/ChangeLog: > > * breakpoint.h (struct breakpoint_ops) : > Renamed to create_sals_from_location. > : Renamed to decode_location. > Update all callers. > * breakpoint.c (create_sals_from_address_default): Renamed to ... > (create_sals_from_location_default): ... this. > (addr_string_to_sals): Renamed to ... > (location_to_sals): ... this. > (decode_linespec_default): Renamed to ... > (decode_location_default): ... this. > (base_breakpoint_create_sals_from_address): Renamed to ... > (base_breakpoint_create_sals_from_location): ... this. > (bkpt_create_sals_from_address): Renamed to ... > (bkpt_create_sals_from_location): ... this. > (bkpt_decode_linespec): Renamed to ... > (bkpt_decode_location): ... this. > (bkpt_probe_create_sals_from_address): Renamed to ... > (bkpt_probe_create_sals_from_location): ... this. > (tracepoint_create_sals_from_address): Renamed to ... > (tracepoint_create_sals_from_location): ... this. > (tracepoint_decode_linespec): Renamed to ... > (tracepoint_decode_location): ... this. > (tracepoint_probe_create_sals_from_address): Renamed to ... > (tracepoint_probe_create_sals_from_location): ... this. > (tracepoint_probe_decode_linespec): Renamed to ... > (tracepoint_probe_decode_location): ... this. > (strace_marker_create_sals_from_address): Renamed to ... > (strace_marker_create_sals_from_location): ... this. > (decode_linespec_default): Renamed to ... > (decode_location_default): ... this. Still approved. :-)