From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44322 invoked by alias); 19 Oct 2018 12:10:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44251 invoked by uid 89); 19 Oct 2018 12:10:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=Kevin, Buettner, buettner X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Oct 2018 12:10:44 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9JC8XFa035607 for ; Fri, 19 Oct 2018 08:10:41 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2n7esk0pnv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 19 Oct 2018 08:10:41 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Oct 2018 13:10:40 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 19 Oct 2018 13:10:39 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9JCAcfs63897784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 19 Oct 2018 12:10:38 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 09C4711C04A; Fri, 19 Oct 2018 12:10:38 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DDC7B11C04C; Fri, 19 Oct 2018 12:10:37 +0000 (GMT) Received: from oc0404454431.ibm.com (unknown [9.152.222.49]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 19 Oct 2018 12:10:37 +0000 (GMT) From: Andreas Arnez To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] S390: Fix crash when remote tdesc doesn't define vec128 References: <20181019043248.15c3753f@pinnacle.lan> Date: Fri, 19 Oct 2018 12:10:00 -0000 In-Reply-To: <20181019043248.15c3753f@pinnacle.lan> (Kevin Buettner's message of "Fri, 19 Oct 2018 04:32:48 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain x-cbid: 18101912-0008-0000-0000-00000281F3F1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18101912-0009-0000-0000-000021EB65F1 Message-Id: X-SW-Source: 2018-10/txt/msg00430.txt.bz2 On Fri, Oct 19 2018, Kevin Buettner wrote: > Hi Andreas, > > It needs a ChangeLog entry, but aside from that it looks okay to me. Thanks. Here's the missing ChangeLog entry: gdb/ChangeLog: * s390-tdep.c (s390_pseudo_register_type): For v0-v15 don't yield the possibly non-existent tdesc type 'vec128', but the type of raw register v16 instead. Pushed with that as commit #0667c50682. -- Andreas