From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4787 invoked by alias); 8 Apr 2002 09:34:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4740 invoked from network); 8 Apr 2002 09:34:38 -0000 Received: from unknown (HELO dell-pe2450-3.cambridge.redhat.com) (195.224.55.225) by sources.redhat.com with SMTP; 8 Apr 2002 09:34:38 -0000 Received: from north-pole.nickc.cambridge.redhat.com (host217-35-25-247.in-addr.btopenworld.com [217.35.25.247]) by dell-pe2450-3.cambridge.redhat.com (Postfix) with ESMTP id D65F784788; Mon, 8 Apr 2002 10:34:37 +0100 (BST) Received: from north-pole.nickc.cambridge.redhat.com.nickc.cambridge.redhat.com (localhost [127.0.0.1]) by north-pole.nickc.cambridge.redhat.com (Postfix) with ESMTP id 6E9191C34D; Mon, 8 Apr 2002 10:34:14 +0100 (BST) To: Andrew Cagney Cc: Anthony Green , gdb-patches@sources.redhat.com Subject: Re: [rfa] Add -m; Was: ARM sim patch: increase default target memory References: <200203171650.g2HGo8714138@louie.sfbay.redhat.com> <3CB07C82.3040902@cygnus.com> From: Nick Clifton Date: Mon, 08 Apr 2002 02:34:00 -0000 In-Reply-To: <3CB07C82.3040902@cygnus.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-04/txt/msg00292.txt.bz2 Hi Andrew, > The attatched patch (er, hack), adds support for the -m flag from > the GDB command line (vis (gdb) target sim -m). Hmm, this looks generally OK to me, except that I would recommend using "strtoul" instead of "atoi" to convert the string into a number, so that hex values can be specified as well as decimal. I would also suggest that you consider adding support for a megabyte postfix so that the user could do: -m 6M to set up a 6 megabyte virtual memory, instead of having to type: -m 6291456 > It also sets the default memory size back to something consistent > with the other simulators. This will stop the java tests from running, so maybe you should also add the new switch to the java test harness so that they do not fail. Cheers Nick