Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Emi SUZUKI <emi-suzuki@tjsys.co.jp>
Cc: gdb-patches@sourceware.org, Daniel Jacobowitz <dan@codesourcery.com>
Subject: Re: [RFC] checking the Z-packet support on gdbserver
Date: Tue, 18 Sep 2007 21:17:00 -0000	[thread overview]
Message-ID: <m3fy1bwu5k.fsf@codesourcery.com> (raw)
In-Reply-To: <20070914.183913.226021396.emi-suzuki@tjsys.co.jp> (Emi SUZUKI's message of "Fri, 14 Sep 2007 18:39:13 +0900")


Emi SUZUKI <emi-suzuki@tjsys.co.jp> writes:
> From: Jim Blandy <jimb at codesourcery.com>
> Subject: Re: [RFC] checking the Z-packet support on gdbserver
> Date: Thu, 13 Sep 2007 10:05:50 -0700
>
>> Emi SUZUKI <emi-suzuki@tjsys.co.jp> writes:
>> > Would anyone give me any comments how it should be treated as a whole?
>> > Defines another packet for it?  Applies as proposed and notes "it
>> > might not work with older versions of gdbserver" ?
>> 
>> I wonder, would it make sense to have GDB assume that hardware
>> watchpoints are *not* available on remote targets, and then have
>> gdbserver send a 'qSupported' packet stubfeature that tells GDB that
>> hardware watchpoints are okay?
>
> Well, I understood casually that the answer of 'qSupported' packet
> would tell the support for the other 'q' packets from the current
> implementaion...  According to the description in the info, definitely
> it would make sense.  How about the attached?

This looks good to me.  Dan should probably approve the gdbserver
side, but that looks appropriately done to me, too.

In remote.c, I noticed two things:

- You want 'resource', not 'resouce'.

- It seems to me that hardware_resource_to_Z_packet should just return
  one of the PACKET_Z[0-4], ... constants directly, instead of
  returning a Z_PACKET_* constant and letting
  remote_check_Zpacket_support convert that to a PACKET_Z? enum value.


  parent reply	other threads:[~2007-09-18 21:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-13 12:09 [RFC] checking the Z-packet suppport " Emi SUZUKI
2007-09-13 17:05 ` Jim Blandy
2007-09-14  9:40   ` [RFC] checking the Z-packet support " Emi SUZUKI
2007-09-14 12:15     ` Daniel Jacobowitz
2007-09-18 21:17     ` Jim Blandy [this message]
2007-09-18 21:28       ` Daniel Jacobowitz
2007-09-18 21:45     ` Jim Blandy
2007-09-20  9:49       ` Emi SUZUKI
2007-09-14 12:15 ` [RFC] checking the Z-packet suppport " Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fy1bwu5k.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=dan@codesourcery.com \
    --cc=emi-suzuki@tjsys.co.jp \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox