From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13873 invoked by alias); 4 Jun 2009 21:30:05 -0000 Received: (qmail 13854 invoked by uid 22791); 4 Jun 2009 21:30:03 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Jun 2009 21:29:52 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n54LTo9D002934 for ; Thu, 4 Jun 2009 17:29:50 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n54LTbBx010183; Thu, 4 Jun 2009 17:29:37 -0400 Received: from opsy.redhat.com (vpn-12-161.rdu.redhat.com [10.11.12.161]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n54LTa9c008140; Thu, 4 Jun 2009 17:29:36 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 8998C378615; Thu, 4 Jun 2009 15:29:35 -0600 (MDT) To: Sami Wagiaalla Cc: GDB Patches Subject: Re: [RFA] Renam sutruct using_direct members References: <4A1AE557.6070300@redhat.com> From: Tom Tromey Reply-To: tromey@redhat.com Date: Thu, 04 Jun 2009 21:30:00 -0000 In-Reply-To: <4A1AE557.6070300@redhat.com> (Sami Wagiaalla's message of "Mon\, 25 May 2009 14\:37\:11 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00082.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> struct using_direct Sami> { Sami> char *inner; Sami> char *outer; Sami> struct using_direct *next; Sami> }; Sami> The names inner and outer are not very clear. I certainly found it Sami> unintuitive while working on namespace support. This patch renames them Sami> no import_src and import_dest respectively Seems reasonable. I agree that these names are not very clear. Sami> 2009-05-25 Sami Wagiaalla Sami> * cp-support.h (struct using_direct): renamed members inner, and Sami> outer to import_src, and import_dest respectively. Sami> Updated all reverences. A few nits about the ChangeLog... It should mention all files that were changed. Descriptions should start with a capital letter. All lines should start with a single TAB (the second one did not in the email). For this one I would write: 2009-05-25 Sami Wagiaalla * cp-support.h (struct using_direct): Rename members inner and outer to import_src, and import_dest respectively. * cp-namespace.c (cp_add_using_directive): Update. (cp_add_using): Update. (cp_copy_usings): Update. (cp_lookup_symbol_namespace): Update. * cp-support.c (make_symbol_overload_list_using): Update. Also, your patch seems to have been wrapped at some places... wrong MUA setting somewhere? This is ok with an updated ChangeLog. Tom