From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20729 invoked by alias); 1 Mar 2010 17:21:36 -0000 Received: (qmail 20718 invoked by uid 22791); 1 Mar 2010 17:21:35 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Mar 2010 17:21:31 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o21HLTZg025438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Mar 2010 12:21:29 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o21HLTMg021532; Mon, 1 Mar 2010 12:21:29 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o21HLSMh008119; Mon, 1 Mar 2010 12:21:28 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id D524B378267; Mon, 1 Mar 2010 10:21:27 -0700 (MST) From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: [RFA] defs.h: Define GDB_DEFAULT_TARGET_[WIDE_]CHARSET for Cygwin and MingW builds References: <20100228130500.GG5683@calimero.vinschen.de> <20100228142905.GB1556@caradoc.them.org> <20100228150318.GA32463@calimero.vinschen.de> <20100228184749.GA17375@caradoc.them.org> <20100228192159.GP5683@calimero.vinschen.de> <20100228222702.GC29360@caradoc.them.org> <20100301103125.GB9730@calimero.vinschen.de> Reply-To: tromey@redhat.com Date: Mon, 01 Mar 2010 17:21:00 -0000 In-Reply-To: <20100301103125.GB9730@calimero.vinschen.de> (Corinna Vinschen's message of "Mon, 1 Mar 2010 11:31:25 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00020.txt.bz2 >>>>> "Corinna" == Corinna Vinschen writes: Corinna> +void Corinna> +set_auto_target_wide_charset (char *charset) Argument should be const. Corinna> +void Corinna> +set_auto_target_charset (char *charset) Likewise. I think the documentation for these functions (in charset.h) should mention the expected lifetime of the arguments. Corinna> @@ -874,7 +917,7 @@ _initialize_charset (void) [...] Corinna> + auto_target_charset_name = auto_host_charset_name; Corinna> _initialize_windows_nat (void) [...] Corinna> + set_auto_target_charset ("UTF-8"); This seems to introduce an ordering dependency between _initialize functions. My understanding is that we don't allow this. Tom