From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6518 invoked by alias); 30 Mar 2010 22:22:04 -0000 Received: (qmail 6508 invoked by uid 22791); 30 Mar 2010 22:22:04 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 22:22:00 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2UMLvsq031269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Mar 2010 18:21:57 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2UMLuEM032510; Tue, 30 Mar 2010 18:21:57 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2UMLuNq013813; Tue, 30 Mar 2010 18:21:56 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 02ACA37950A; Tue, 30 Mar 2010 16:21:55 -0600 (MDT) From: Tom Tromey To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] sim: use socklen_t with accept() References: <1269986875-1519-1-git-send-email-vapier@gentoo.org> Reply-To: tromey@redhat.com Date: Tue, 30 Mar 2010 22:22:00 -0000 In-Reply-To: <1269986875-1519-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Tue, 30 Mar 2010 18:07:55 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01089.txt.bz2 >>>>> "Mike" == Mike Frysinger writes: Mike> 2010-03-30 Mike Frysinger Mike> * configure.ac: Check for socklen_t. Mike> * configure, config.in: Regenerated. Mike> * dv-sockser.c (connected_p): Change addrlen type to socklen_t. Somewhere, probably dv-sockser.c, you also need this bit: #ifndef HAVE_SOCKLEN_T typedef int socklen_t; #endif Mike> Note: this config.in diffstat is larger because the regen tweaked the Mike> comment style for a lot of defines ... not sure if this is correct Make sure you use the exact same versions of the autotools as currently used in the tree. I download the canonical versions from gnu.org and install them all in a fresh $prefix for gdb hacking. You can't use different versions (even minor versions) or distro variants, as they cause churn in the repository. Tom