From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12152 invoked by alias); 4 Jun 2010 16:49:43 -0000 Received: (qmail 12136 invoked by uid 22791); 4 Jun 2010 16:49:41 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jun 2010 16:49:35 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o54GnJ5x028487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Jun 2010 12:49:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o54GnIfu003687; Fri, 4 Jun 2010 12:49:19 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o54GnIxi008473; Fri, 4 Jun 2010 12:49:18 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id E829B37897F; Fri, 4 Jun 2010 10:49:17 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: Joel Brobecker , Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [PATCH] Forbid watchpoint on a constant value References: <20100521070500.GA30452@host0.dyn.jankratochvil.net> <201005211824.20290.sergiodj@redhat.com> <201005211912.39680.sergiodj@redhat.com> <20100528231122.GO3019@adacore.com> <20100604135323.GA5527@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Fri, 04 Jun 2010 16:49:00 -0000 In-Reply-To: <20100604135323.GA5527@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Fri, 4 Jun 2010 15:53:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00121.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> The former comment was vague enough I agreed with it. But the new one is Jan> explicit enough to be unfortunately IMO incorrect. Jan> Return non-zero if EXP is verified as constant. Returned zero Jan> means EXP is variable. Also the constant detection may fail for Jan> some constant expressions and in such case still falsely return Jan> zero. Jan> OK this way? Sure. Tom