Re: [patch] Add an evaluation function hook to Python breakpoints.

Pedro Alves
2010-12-13T15:07:40Z

On Monday 13 December 2010 14:56:10, Phil Muldoon wrote:
> Pedro Alves <pedro@codesourcery.com> writes:
>
> > Can you factor out the PyObject manipulations and the actual evaluation
> > of the condition to pythong/py-breakpoint.c? Say, to a
> > new "py_breakpoint_evaluate (struct breakpoint_object *, ...)" function.
> > The driving idea being to get rid of the need to now include
> > python-internal.h.
>
> Sure I've no problem with that. I think we would still have to include
> python.h (but not python-internal.h) inside a HAVE_PYTHON conditional, as
> the function would be exposed from py_breakpoint.c via python.h.

Right. That's okay.

> Is that ok? Or maybe I misread your intentions.

You got it.

--
Pedro Alves