From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22818 invoked by alias); 18 Feb 2011 15:52:46 -0000 Received: (qmail 22802 invoked by uid 22791); 18 Feb 2011 15:52:45 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Feb 2011 15:52:40 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1IFqU1H010092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Feb 2011 10:52:30 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1IFqTdc010021; Fri, 18 Feb 2011 10:52:29 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1IFqSRc017798; Fri, 18 Feb 2011 10:52:29 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 89422378509; Fri, 18 Feb 2011 08:52:28 -0700 (MST) From: Tom Tromey To: Yao Qi Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver References: <4D30E23F.3080103@codesourcery.com> <4D375F44.70504@codesourcery.com> <201101281504.38962.pedro@codesourcery.com> <4D550834.6080807@codesourcery.com> <4D55FAB4.7090001@codesourcery.com> Date: Fri, 18 Feb 2011 15:53:00 -0000 In-Reply-To: (Tom Tromey's message of "Mon, 14 Feb 2011 10:57:58 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00467.txt.bz2 Tom> It is vaguely bogus due to the dummy-config.h and PACKAGE_NAME Tom> stuff. Autoconf doesn't seem to let you turn this off, and we end Tom> up with conflicts. Thinking about this more -- I am not so sure we should be doing any checks in common/configure. Right now the only source in common/ does this: #ifdef GDBSERVER #include "server.h" #else #include "defs.h" #include "gdb_string.h" #endif Each branch here includes the relevant config.h from the parent project. If common/ does its own checks then it seems like we can get into real configure confusion: C macros defined different ways in different places, maybe conflicting. So I am inclined not to change my patch. I am going to check it in, after investigating the cygnus-vs-foreign automake option. Actually, it seems we could go a step further and just remove common's build stuff and require the gdb and gdbserver Makefiles to build the objects. I didn't look more deeply into this idea. If it has a drawback, I would like to know. Tom