From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79621-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18179 invoked by alias); 14 Mar 2011 16:27:34 -0000
Received: (qmail 18124 invoked by uid 22791); 14 Mar 2011 16:27:31 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 16:27:22 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2EGRDHL000333	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 14 Mar 2011 12:27:13 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2EGRDFI015349;	Mon, 14 Mar 2011 12:27:13 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2EGRCLV014442;	Mon, 14 Mar 2011 12:27:12 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 8CCEB378CA1; Mon, 14 Mar 2011 10:27:10 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Eli Zaretskii'" <eliz@gnu.org>, <gdb-patches@sourceware.org>
Subject: Re: [RFA-v2] Fix ARI warning about function call in first column
References: <20110312015329.GA20179@sourceware.org>	<010f01cbe157$aebb5cb0$0c321610$@muller@ics-cnrs.unistra.fr>	<18667.385276831$1300008680@news.gmane.org>	<m3vczldagl.fsf@fleche.redhat.com>	<001401cbe261$5490ec40$fdb2c4c0$@muller@ics-cnrs.unistra.fr>
Date: Mon, 14 Mar 2011 17:02:00 -0000
In-Reply-To: <001401cbe261$5490ec40$fdb2c4c0$@muller@ics-cnrs.unistra.fr>	(Pierre Muller's message of "Mon, 14 Mar 2011 17:03:16 +0100")
Message-ID: <m3fwqpd5wi.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00734.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   As Eli had some concerns about that part,
Pierre> I tried to change my patch so that it does add new
Pierre> function declarations split in between return type and 
Pierre> function name.
  
If you want, you can commit the obviously ok ones in the meantime.
Nearly all of your patch seems uncontroversial.

Pierre> -extern PyObject *
Pierre> -create_breakpoint_event_object (PyObject *breakpoint);
Pierre> +extern PyObject * create_breakpoint_event_object (PyObject *breakpoint);
 
Pierre> -extern PyObject *
Pierre> -create_signal_event_object (enum target_signal stop_signal);
Pierre> +extern PyObject * create_signal_event_object (enum target_signal
Pierre> stop_signal);
 
No space after the "*" in these two.

Tom