Re: [patch] [python] python/12686

Tom Tromey
2011-04-20T19:32:57Z

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> Kevin Pouget noticed that when GDB called the Python 'stop' callback,
Phil> the terminal stilled belonged to the inferior. GDB intercepts the
Phil> signal generated from terminal input and it forces GDB into the
Phil> background. While this patch is simple, I would like feedback. I
Phil> believe the terminal is restored to the inferior when the inferior is
Phil> resumed (local tests seem to show this), but I am not totally sure. Is
Phil> acquiring the terminal the right thing to do here? I was trying to think
Phil> of a scenario where the Python method would need the inferior terminal,
Phil> but could not.

Phil> Comments?

I don't think we want to do this here.

I'm not really sure of the implications, but it isn't something that
most implementations of the `stop' method are going to want.
If we really need to, we can provide some explicit functions to
manipulate this state from Python. TBH I think asking the user
questions here is weird.

Tom